I suggest that if you do build a mob trap, you should use one of Etho's designs. I strongly believe that they are the most efficient designs.
The one ivy built is a modified version of Etho's designs. It has over 4000 blocks capable of hostile mob spawning, all in an area less than 30x30x128.